Repository navigation
Migrate Compose touch and input snippets - #1118
Open
pengzhi-cb wants to merge 9 commits into
Open
pengzhi-cb wants to merge 9 commits into
pengzhi-cb wants to merge 9 commits into
Conversation
pengzhi-cb
changed the title
pengzhi-cb
force-pushed
the
pengzhi-cb/compose-migrate-swipeable
branch
from
September 29, 2026 21:56
a0a6981 to
aa14dc4
Compare
pengzhi-cb
changed the title
pengzhi-cb
marked this pull request as ready for review
September 29, 2026 22:08
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
pengzhi-cb
changed the title
kkuan2011
reviewed
Oct 2, 2026
edward-williams-stellarelements
pushed a commit
to StellarElements/android-dac-snippets
that referenced
this pull request
Oct 5, 2026
The nested-scroll-modifiers page was queued twice, and it's already migrated in android#1118. Both pull requests add the same layout files, so this branch leaves the page to android#1118: - GesturesSnippets.kt goes back to main. The three new interop region tags, their imports, and the @OptIn on NestedScrollInterop are removed, and the stand-in object R that backs the existing interop_activity region is restored. - The four layouts that were added only for those snippets are removed: activity_main, fragment_bottom_sheet, list_item, and view_in_compose_nested_scroll_interop.
edward-williams-stellarelements
added a commit
to StellarElements/android-dac-snippets
that referenced
this pull request
Oct 5, 2026
The nested-scroll-modifiers page was queued twice, and it's already migrated in android#1118. Both pull requests add the same layout files, so this branch leaves the page to android#1118: - GesturesSnippets.kt goes back to main. The three new interop region tags, their imports, and the @OptIn on NestedScrollInterop are removed, and the stand-in object R that backs the existing interop_activity region is restored. - The four layouts that were added only for those snippets are removed: activity_main, fragment_bottom_sheet, list_item, and view_in_compose_nested_scroll_interop.
kkuan2011
reviewed
Oct 8, 2026
kkuan2011
left a comment
kkuan2011
left a comment
Contributor
There was a problem hiding this comment.
Looks good once comments addressed
pengzhi-cb
force-pushed
the
pengzhi-cb/compose-migrate-swipeable
branch
from
October 8, 2026 21:33
db5db01 to
1f9b9e9
Compare
kkuan2011
approved these changes
Oct 8, 2026
pengzhi-cb
force-pushed
the
pengzhi-cb/compose-migrate-swipeable
branch
from
October 9, 2026 15:31
dff1ab1 to
f7e993e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code snippets are for:
Total: 3 code snippets (3 Kotlin and 0 XML) across 1 page.
Resource migration notes
view_in_compose_nested_scroll_interop.xml,list_item.xml, andfragment_bottom_sheet.xml) were added tocompose/snippets/src/main/res/layout/because the tagged Kotlin snippets inGesturesSnippets.ktreference their resource symbols (R.layout.view_in_compose_nested_scroll_interop,R.id.main_list,R.layout.list_item,R.layout.fragment_bottom_sheet, andR.id.compose_view) and will not compile without them.inflate(...)andfindViewById(...)calls in the guide page code blocks.List of modifications
title = {},parameter toTopAppBar(...)and replaced the trailing// ...comment inNestedScrollInteropAdapterwith// [START_EXCLUDE]override fun getItemCount(): Int = items.size// [END_EXCLUDE]inNestedScrollInteropComposeParentWithAndroidChildExample(android_compose_touchinput_scroll_nested_scroll_interop_compose_parent) so the snippet compiles.android.R.layout.list_itemwithR.layout.list_iteminViewInComposeNestedScrollInteropExample(android_compose_touchinput_scroll_view_in_compose_interop) (Required for the Kotlin snippet to compile) and formattedscrollable(...)arguments across lines.view_in_compose_nested_scroll_interop.xml,list_item.xml, andfragment_bottom_sheet.xmlundercompose/snippets/src/main/res/layout/(Required for the Kotlin snippet to compile).Snippets not migrated
touchinput_gestures_nested_scroll_interop.xmlon GitHub via{% includecode %}).